Page 1 of 1

Patch for Events (It's dark condition)

Posted: Sat Sep 18, 2010 3:12 pm
by poegje
Here is a patch that puts the device status change back in CheckDeviceChangeEvents and it fixes the Dark boolean in CheckCondition.
I hope the latter works for everyone and that it doesn't wreck something else. (It doesn't as far as i could tell anyway).

I think these are temporary fixes as Geert-Jan van den Hurk is already working on the code as far as i understand.

Re: Patch for Events (It's dark condition)

Posted: Sat Sep 18, 2010 4:13 pm
by RDNZL
Thanks will add it, Geerts-Jans code is much cleaner than mine, but certain conditions where not checked.
So I reversed some changes back until I have more time to investigate this, the events module is one of the difficult parts although it doesn't seem like that if you take a quick look at it...

You can view all of Geert-Jans work if you browse a few revisions back in Browse Source on the website for Events.module.

Re: Patch for Events (It's dark condition)

Posted: Sat Sep 18, 2010 4:23 pm
by poegje
I saw Geert-Jans work indeed. It is much better code than i could do, so that's why i just made these small fixes, hoping he will continue his good work :)