New action type: Execute external program

Forum about Domotiga Open Source Home Automation for Linux.

Moderator: RDNZL

Post Reply
hhg
Starting Member
Starting Member
Posts: 20
Joined: Sun Jul 18, 2010 6:45 pm
Location: Denmark

New action type: Execute external program

Post by hhg »

Hi

Still very new to DomotiGa and this forum, but I'm being more and more impressed by Domotiga - A very flexible HA program.

I have a need to reconfigure my camera at sunset and sunrise, and was thinking: Well, DomotiGa knows when it is sunset...
So I added a new action type: Execute external program. See attached screen shot.
Edit Action Form
Edit Action Form
editaction.png (21.15 KiB) Viewed 3257 times
The patch is against revision 372. I hope others will find it useful. And that Ron will include it in a future version.

Best regards
hhg
Attachments
execute_action.patch.tar.gz
(881 Bytes) Downloaded 294 times
User avatar
RDNZL
Forum Moderator
Forum Moderator
Posts: 1008
Joined: Sun Sep 24, 2006 1:45 pm
Location: Dordrecht, The Netherlands
Contact:

Re: New action type: Execute external program

Post by RDNZL »

Hi,

thanks for your work!

Will add it to the code repository once I have cleared my jet-lag after returning yesterday from a long stay in Indonesia.
Will also post other DomotiGa code still laying around here.
Regards, Ron.
User avatar
RDNZL
Forum Moderator
Forum Moderator
Posts: 1008
Joined: Sun Sep 24, 2006 1:45 pm
Location: Dordrecht, The Netherlands
Contact:

Re: New action type: Execute external program

Post by RDNZL »

I have added your code to revision 390.
Thanks.
Regards, Ron.
hhg
Starting Member
Starting Member
Posts: 20
Joined: Sun Jul 18, 2010 6:45 pm
Location: Denmark

Re: New action type: Execute external program

Post by hhg »

Hi Ron

Thanks for adding.

I've noticed you added (in rev 391) code to set the tab index. That is actually already handlet in your code in line 56-63 IF the table actiontypes is populated - Or are you going to dump this table? Is it used for anything else?

It could be replaced with this line:

Code: Select all

tabActionTypes.Index = rResult!type - 1
Either way, it work as it is, i've was just wondering...

Best regards
hhg
User avatar
RDNZL
Forum Moderator
Forum Moderator
Posts: 1008
Joined: Sun Sep 24, 2006 1:45 pm
Location: Dordrecht, The Netherlands
Contact:

Re: New action type: Execute external program

Post by RDNZL »

For some reason it didn't work the way I wanted, but I will review the code and change it back if needed.
Regards, Ron.
Post Reply

Return to “DomotiGa Forum”