Events run but no action performed in 0.1.188

[dali]

After upgrading to 0.1.188, action stopped working.
I can see that the events have been trigged, but no actions are performed, ie the "Turn of lights at 23:00" is trigged at the right time, but the lights doesn't get turned of.

Anyone else experiencing the same?

[treblasnirp]

Please post the debug of the event.
Condition value sometimes only a T instead of a True

[hhg]

I see the same: Events been trigged, Actions not performed. From the log:

Code: Select all

2010/09/25 00:00:00 [Events] Check condition evening <> night = True
2010/09/25 00:00:00 [Events] Check condition night = night = True
2010/09/25 00:00:00 [Events] GlobalVar Change trigger on 'Time_Of_Day' night = night
2010/09/25 00:00:00 [Events] Event 'Sluk ventilator om natten' is triggered, running action(s).
2010/09/25 00:00:00 [Events] Action 'Set Ventilation to Normal Speed' executed!

So RunAction() is been called, but the device is not activated/changed.
I think the problem is this line (Events.module line 257):

Code: Select all

IF Comp(rResultAction!param2, "Value") = 0 THEN

In my actions table param2 is "Value1", so after changing the above line to "Value1", actions do run

Regards
hhg

[dali]

That change worked for me too.

[RDNZL]

Ok will check this.
Do you mean older event/actions made before r420 don't work but new created ones do?
Or they don't either?
I have alot of events and actions tested, but I know of 3 people having problems with it..
So I will check your fix and add it.
In the mean time I have added alot of debug info to Events.module in r426.
I really want to make it 100% working correctly, and I think we are almost there.
The possibilities are endless, with the recent addition of IRRemote, Globalvar triggers and SMS, e-mail, twitter and set var action types.
More will follow.

Things to add too are timers (want to have events working ok before adding that) and a dynamic number of actions instead of 3.

If problems are still there please e-mail or pm me the event debug output whil running r426 or higher. (events can contain private info)
You can also use contact form on domotiga.nl for this,

[RDNZL]

Yep confirmed, bug fixed in revision 427.

Thanks hhg for your fix, and sorry you all had to sleep with the lights on because of this bug

[hhg]

Your Welcome

DomotiGa is getting better an better for each day, and I'm only happy to contribute. And I got my sleep
Looking forward to see timers in the system.
Thanks for a great system.

Regards
hhg

[dali]

The problem got solved very quickly, and that's a big "thumbs up" for DomotiGa.

Timers sounds very nice.
I would also like to have a way to set a trigger like "Sunset +/- X hours", eg "If time is 2 hours before sunset, turn on lights". Is there a way to solve that?

[treblasnirp]

The problem got solved very quickly, and that's a big "thumbs up" for DomotiGa.

Timers sounds very nice.
I would also like to have a way to set a trigger like "Sunset +/- X hours", eg "If time is 2 hours before sunset, turn on lights". Is there a way to solve that?

I solved that problem with Kaku ABST-604
You decide the time of switching.